recurse_symlinks equivalent for all python versions. #152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull request overview
This PR replaces the use of Path.rglob() with the recurse_symlinks=True parameter (introduced in Python 3.13) with a custom _walk_all() function that works across all Python versions. The change ensures backward compatibility while maintaining the same functionality of recursively traversing directories and following symbolic links.
Changes:
- Added a new
_walk_all()helper function that usesos.walk()withfollowlinks=True - Replaced
source.rglob("*", recurse_symlinks=True)with_walk_all(source) - Added
osimport to support the new implementation
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace #151 with an equivalent that works with all python versions.