-
Notifications
You must be signed in to change notification settings - Fork 24
Add option to run CLI tests from python, and add example test. #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
| @@ -0,0 +1,49 @@ | ||||
| from pathlib import Path | ||||
|
||||
| from pathlib import Path |
Copilot
AI
Jan 12, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The filecmp.dircmp comparison only performs a shallow comparison and doesn't recursively check subdirectories. This means that differences in files within subdirectories (like "subdir/file2.txt") may not be caught by the assertions on diff_files, left_only, and right_only. While the explicit file content checks on lines 47-49 will catch this specific case, consider using filecmp.dircmp recursively or using a recursive comparison function to make the test more robust and comprehensive.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment should start with a capital letter and use proper sentence structure. Consider revising to: "Getting argv optionally from the caller to enable calls from Python (generally for testing, but could be used for other purposes)."