Prepare for alpha (0.1.0) release#5
Merged
ptomato merged 19 commits intojs-temporal:mainfrom Jul 8, 2021
Merged
Conversation
justingrant
force-pushed
the
prepare-for-0.1.0
branch
from
b2a0716 to
0a8bf06
Compare
ptomato
requested changes
Jul 8, 2021
Contributor
ptomato
left a comment
ptomato
left a comment
There was a problem hiding this comment.
There's something I need to check out re. a bug fix in the getNextTransition/getPreviousTransition code, and I'd recommend not removing the big blocks of PlainDate/PlainTime tests, but otherwise this looks good.
Fixes #1487. Also fixes bug in units for PlainTime's until/since.
We use the operation from es-abstract in some places, and a snapshot of Number.isInteger in others. Use IsInteger in order to correspond more with the spec text.
Fixes #1590
* update version to 0.1.0 * copy recent code & test changes from original repo * switch CI tests to run Node 14 and 16 (remove 15) * run prettier --fix * update dependencies * update .gitignore
ptomato
force-pushed
the
prepare-for-0.1.0
branch
from
0a8bf06 to
55183c8
Compare
ptomato
approved these changes
Jul 8, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.