fit, flow & reposition (clear mess up history)#88
fit, flow & reposition (clear mess up history)#88jojosati wants to merge 1 commit intojschr:masterfrom
Conversation
|
Hey @jojosati I took a look at your pull request and saw that you are listening to the change event in order to reapply the layout on the modal. Why do you listen to the change event when that event is fired by input elements? As a user of the fit/flow/reposition features you added am I expected to fire a change event on the modal element when I want it to reapply the layout? If so it seems like I could just call the layout method myself. Can you clear things up for me? |
|
I think there are 2 ways to detect the modal size changing.
When using modal as popup input form, change event can bubble to the modal automaticly. At first time I am using modal this way, so I choose the change event because it consume less processor than polling. Example In my form I have a checkbox for "more option" to collapse/expand some less use inputs. When using modal as ajax container, need programatic trigger when finish loading and apply data to the modal. When using modal as interactive content - collapsable, resizable or toggle hide/show some elements. Leave it to programatice trigger. Change event does some checkings and optimizations before layout invoke,
|


sorry for previous pull request.
this branch has cleared some messed up historty
and submit only the fit, flow & reposition code.