Skip to content

Keep historical chat diffs inspectable#177

Merged
jsgrrchg merged 3 commits into
mainfrom
presentation/keep-chat-diff-cards
Jun 1, 2026
Merged

Keep historical chat diffs inspectable#177
jsgrrchg merged 3 commits into
mainfrom
presentation/keep-chat-diff-cards

Conversation

@jsgrrchg
Copy link
Copy Markdown
Owner

Summary

  • Keep historical chat diffs rendered as the same inspectable diff cards instead of compacting them into Earlier change summaries.
  • Remove the Recent change presentation path and the two-cycle recency cutoff from the chat timeline.
  • Update chat message/list tests to cover the new presentation invariant.

Why

The old split between recent and earlier diff cards was purely presentational. It made older changes harder to inspect even though the chat diff cards are not the review/accept/reject surface. This keeps the timeline consistent while leaving the review, hunks, accept/reject, and buffer flows untouched.

Validation

  • npm --prefix apps/desktop test -- src/features/ai/components/AIChatMessageItem.test.tsx src/features/ai/components/AIChatMessageList.test.tsx

@jsgrrchg
Copy link
Copy Markdown
Owner Author

Initially this logic was implemented to keep the chat streaming performant, but during testing, I found that it was not needed. Now users will be able to inspect every diff in the chat streaming no matter how old it is.

@jsgrrchg jsgrrchg marked this pull request as ready for review June 1, 2026 17:03
@jsgrrchg jsgrrchg merged commit 90ae9d2 into main Jun 1, 2026
7 checks passed
@jsgrrchg jsgrrchg deleted the presentation/keep-chat-diff-cards branch June 1, 2026 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant