This repository was archived by the owner on Jan 10, 2020. It is now read-only.
Open
Conversation
Collaborator
|
While I like the concept, the patch has a few issues as-is. First of all, rather than using a separate command-line instruction I would rather prefer "markov learn from " be used. learn_from() would thus check if the parameter is an url or a filename and act accordingly. Also, the dependency from w3m is not an approach I like. A better approach would be to get the page content using rbot's own httputil functions to get the text, clean it up using the rbot methods such as ircify_html or riphtml, and then iterate of the lines with .each_line. The code could actually remain in the same block, just name the source |
Acrophobia for IRC. More information on acrophobia is available on wikipedia. Includes a Hall of Fame (scoreboard). Unfortunately doesn't work on a per-channel basis since some secrecy is required. Signed-off-by: Andy Hill <hillad@gmail.com>
Add acrophobia plugin.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request adds in a learn by url plugin which is activated by markov learn_url