Open
Conversation
Author
|
Hi maintainers, this PR addresses #2165. I’d appreciate your review whenever convenient. Happy to make any changes if needed. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GitHub Issue: json-schema-org/website#2165
Summary:
This PR cleans up
ambassadors.jsonby removing inline Markdown links and plain URLs from ambassador bios and converting them to plain text.Changes Made
[Redocly](https://github.com/redocly)[OpenAPI Initiative](https://github.com/OAI)https://apidesignmatters.substack.com/Motivation
Previously, ambassador bios contained embedded Markdown links and raw URLs directly inside the JSON data. This mixed presentation concerns with content data.
With the introduction of the
parseBiofunction inAmbassadorsCard.tsx, linking is now handled at the component level. The JSON file remains clean and presentation-agnostic, while the UI layer dynamically converts specific keywords into styled external links.Result
Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)
No
[JUSTIFICATION]
This change is a small refactor and content cleanup that improves separation of concerns between data and presentation. It does not introduce a new architectural pattern, system-level decision, or long-term structural change. Therefore, an ADR is not required.