Skip to content

Update ambassadors.json#1013

Open
waygeance wants to merge 1 commit intojson-schema-org:mainfrom
waygeance:changes-for-issue-2312
Open

Update ambassadors.json#1013
waygeance wants to merge 1 commit intojson-schema-org:mainfrom
waygeance:changes-for-issue-2312

Conversation

@waygeance
Copy link

@waygeance waygeance commented Mar 3, 2026

GitHub Issue: json-schema-org/website#2165

Summary:

This PR cleans up ambassadors.json by removing inline Markdown links and plain URLs from ambassador bios and converting them to plain text.

Changes Made

  • Removed Markdown link syntax such as:
    • [Redocly](https://github.com/redocly)
    • [OpenAPI Initiative](https://github.com/OAI)
  • Removed direct URL references such as:
    • https://apidesignmatters.substack.com/
  • Updated bios to use clean plain text (e.g., "Redocly", "OpenAPI Initiative", "API Design Matters")

Motivation

Previously, ambassador bios contained embedded Markdown links and raw URLs directly inside the JSON data. This mixed presentation concerns with content data.

With the introduction of the parseBio function in AmbassadorsCard.tsx, linking is now handled at the component level. The JSON file remains clean and presentation-agnostic, while the UI layer dynamically converts specific keywords into styled external links.

Result

  • Cleaner and more maintainable JSON data
  • Proper separation of data and presentation
  • Centralized link handling logic inside the React component
  • No functional change to user-facing behavior

Do you think resolving this issue might require an Architectural Decision Record (ADR)? (significant or noteworthy)

No

[JUSTIFICATION]

This change is a small refactor and content cleanup that improves separation of concerns between data and presentation. It does not introduce a new architectural pattern, system-level decision, or long-term structural change. Therefore, an ADR is not required.

@waygeance
Copy link
Author

Hi maintainers, this PR addresses #2165. I’d appreciate your review whenever convenient. Happy to make any changes if needed. ☺️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant