feat(benchmarks): improve measurement accuracy and add missing benchmarks#6
Merged
feat(benchmarks): improve measurement accuracy and add missing benchmarks#6
Conversation
…arks - Restructure compact benchmarks to pre-populate history/tombstones in setup - Fix delete benchmark to use unique keys per iteration (no restore cycle) - Add benchmarks for find_one, items, and reload methods - Add EDGE_PARAMS (scale=0, scale=1) for boundary testing - Add generator helpers: create_extended_test_table, create_table_with_history, create_table_with_tombstones
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #6 will create unknown performance changesComparing Summary
Benchmarks breakdown
Footnotes
|
Split benchmarks into 11 shards (from 4) to ensure each completes within the 6-minute timeout. Max shard size is now 43 tests (find) which should complete in ~5.7 minutes at ~8s per test. Shard distribution: - load-reload: 38 tests - get: 25 tests - all: 25 tests - find: 43 tests - find-one: 18 tests - write-compact: 32 tests - keys-delete: 31 tests - items: 25 tests - count: 25 tests - has: 31 tests - memory: 18 tests
Split benchmarks into 15 shards to ensure each completes within 5 minutes. Separated slow vs non-slow tests for expensive operations (all, items, keys) using the slow marker. Shard distribution (estimated times): - get: 25 tests (~3m) - count: 25 tests (~3m) - has: 31 tests (~3m) - find-one-delete: 24 tests (~2m) - write-compact: 32 tests (~5m) - load: 19 tests (~4m) - reload: 19 tests (~4m) - keys-ci: 12 tests (~2.5m) - keys-slow: 13 tests (~2.5m) - all-ci: 12 tests (~3m) - all-slow: 13 tests (~3.5m) - items-ci: 12 tests (~3m) - items-slow: 13 tests (~3.5m) - find-high: 19 tests (~3m) - find-other: 24 tests (~4m) Memory tests excluded for now due to memray profiling overhead.
Exclude slow tests from PR benchmarks to ensure completion under 5 minutes. Slow tests take ~24s each vs ~7s for CI tests. Shard distribution (7 shards, ~176 tests total): - load-reload: 12 tests (~1.5m) - get: 12 tests (~1.5m) - find: 30 tests (~3.5m) - find-one-delete: 24 tests (~2m) - write-compact: 32 tests (~5m) - all-keys-items: 36 tests (~4m) - count-has: 30 tests (~3.5m)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compact()performancefind_one,items, andreloadmethodsEDGE_PARAMS(scale=0, scale=1) for boundary testing on appropriate testscreate_extended_test_table,create_table_with_history,create_table_with_tombstones