feat(completion): allow overriding renderer, other rendering-related fixes#168
Open
xdavidwu wants to merge 4 commits into
Open
feat(completion): allow overriding renderer, other rendering-related fixes#168xdavidwu wants to merge 4 commits into
xdavidwu wants to merge 4 commits into
Conversation
like formatHover in hover
Avoid getting a tiny panel with padding only.
🦋 Changeset detectedLatest commit: ed200b6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
✅ Deploy Preview for codemirror-json-schema ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
formatInfofor completion, likeformatHoverfor hover, to let consumer control description rendering.Fix renderer not being applied on enums.
Use renderer only when there are description to avoid visual artifacts. (To check, type property
publishConfigon demo with package.json schema.)