Implement reader support for CalculateDifferences (& various improvements)#7
Open
Freeaqingme wants to merge 1 commit intojuli4n:readersfrom
Open
Implement reader support for CalculateDifferences (& various improvements)#7Freeaqingme wants to merge 1 commit intojuli4n:readersfrom
Freeaqingme wants to merge 1 commit intojuli4n:readersfrom
Conversation
- Add license file - Implement reader support for CalculateDifferences - Allow to use alternate hashing mechanisms (like xxhash)
Owner
|
Thanks for the detailed description, Dolf. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
My suggestion would be to make this branch the new default (and/or merge it with master). Some additional notes:
If you have any requests or suggestions please let me know. Happy to address any!
Edit:
Please don't merge it yet. Had the previous version implemented in my own application, but would like to first implement this version to be sure it doesn't just work in the test files, but also in an existing application.Works :)