add: update scripts for gemma4 26B-A4B testing - #153
Open
jungledesh wants to merge 7 commits into
Open
Conversation
| # Gemma on AMD: bash -lc './start-gemma.sh' and PROFILE_MODEL=gemma | ||
| # (SERVED_NAME already defaults to gemma-4-26b-a4b in start-gemma-amd.sh). | ||
| ENV PROFILE_MODEL=llama | ||
| ENV SERVED_NAME=llama3 |
There was a problem hiding this comment.
AMD Gemma inherits Llama identity
When the AMD container starts ./start-gemma.sh as documented without overriding SERVED_NAME, the image-level llama3 value prevents the launcher from applying its Gemma default, causing Gemma weights to be advertised under a Llama identifier and Profile to omit the correct Gemma-specific diagnostics.
Prompt To Fix With AI
This is a comment left during a code review.
Path: Dockerfile
Line: 198
Comment:
**AMD Gemma inherits Llama identity**
When the AMD container starts `./start-gemma.sh` as documented without overriding `SERVED_NAME`, the image-level `llama3` value prevents the launcher from applying its Gemma default, causing Gemma weights to be advertised under a Llama identifier and Profile to omit the correct Gemma-specific diagnostics.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Greptile Summary
The PR aligns bundled launch and load scripts around explicit model-family and served-name settings, and adds NVIDIA/AMD Gemma 4 launch support. The AMD image-level Llama name currently leaks into the Gemma launcher and prevents correct model identification.
Confidence Score: 4/5
The PR should not merge until the AMD Gemma switch stops inheriting the Llama served name and preserves correct Gemma model identification.
The AMD image exports
SERVED_NAME=llama3, and the new Gemma launcher only supplies its Gemma name when that variable is unset, so the documented switch serves Gemma weights under a Llama identifier and deprives Profile of the correct model metadata.Files Needing Attention: Dockerfile, scripts/start-gemma-amd.sh
Important Files Changed
Flowchart
%%{init: {'theme': 'neutral'}}%% flowchart LR A[AMD image ENV<br/>SERVED_NAME=llama3] --> B[start-gemma.sh] B --> C[start-gemma-amd.sh preserves inherited name] C --> D[vLLM serves Gemma weights as llama3] D --> E[Profile cannot select Gemma metadata]Prompt To Fix All With AI
Reviews (5): Last reviewed commit: "script in dockerfile" | Re-trigger Greptile