Skip to content

Update Timeline Component To Fix Provider Syntax#44

Open
ThatOneAwkwardGuy wants to merge 1 commit into
junwen-k:mainfrom
ThatOneAwkwardGuy:patch-1
Open

Update Timeline Component To Fix Provider Syntax#44
ThatOneAwkwardGuy wants to merge 1 commit into
junwen-k:mainfrom
ThatOneAwkwardGuy:patch-1

Conversation

@ThatOneAwkwardGuy
Copy link
Copy Markdown

I believe this is a small mistake.

I believe this is a small mistake.
@vercel
Copy link
Copy Markdown
Contributor

vercel Bot commented May 25, 2025

@ThatOneAwkwardGuy is attempting to deploy a commit to the junwenk's projects Team on Vercel.

A member of the Team first needs to authorize it.

@junwen-k
Copy link
Copy Markdown
Owner

@ThatOneAwkwardGuy Hello there, thanks so much for your contribution! 😄 You made a great catch — React 19 actually introduced this change to support using context as a provider directly.

I think I may have missed updating some components — probably all the v4 components should be updated to use Context directly instead of Context.Provider though. 👀

@ThatOneAwkwardGuy
Copy link
Copy Markdown
Author

Ah i see, so is v4 specifically for react 19? haven't updated to that yet.

@ducvui2003
Copy link
Copy Markdown

You should split into 2 version, or should use Context.Provider to can use in both react 18 and react 19

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants