fixes for binary state#231
Merged
Merged
Conversation
minrk
force-pushed
the
binary-state
branch
4 times, most recently
from
1a1726c to
8f4a74f
Compare
This was referenced Nov 6, 2015
- avoid changing dict in-place when pulling out buffers - workaround inability to send buffers in open message on Comm init
minrk
force-pushed
the
binary-state
branch
2 times, most recently
from
5d08616 to
dba908b
Compare
Contributor
Author
|
I'll make a separate PR that always serializes Bytes. |
Contributor
There was a problem hiding this comment.
Eventually we will need to add support for binary messages in open on init, because sending state on comm open fixed a state race condition (of course, I failed to link to any issues in the original PR, sigh #84)
Contributor
|
Thanks! |
github-actions
Bot
added
the
resolved-locked
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There appears to be a test for this, but I cannot see how it would ever pass, since sending binary state can never work with master due to mutating the state dict while iterating through it.