support routing updating outputs with display_id#1879
Merged
Conversation
minrk
force-pushed
the
display_data_update
branch
from
327632e to
0c90391
Compare
18 tasks
Member
Author
|
An example notebook for testing with these messages (doesn't require IPython PRs): https://nbviewer.jupyter.org/gist/minrk/1a1e56a611f1ff1e2645f733bdd0e381 |
Member
Author
|
Only missing thing: updating execute_result. |
Member
|
Looking good! |
minrk
changed the title
make update_display handling clearer and separate from regular display_data
minrk
force-pushed
the
display_data_update
branch
from
ce5605f to
c0a6e41
Compare
Member
Author
|
No longer WIP, this should be all set, now. |
rgbkrk
approved these changes
Nov 16, 2016
| } | ||
| } catch(err) { | ||
| console.log(err); | ||
| console.error(err); |
| case 'update_display_data': | ||
| record_output = false; | ||
| json = this.validate_mimebundle(json); | ||
| this.update_display_data(json); |
| json.transient = content.transient; | ||
| json.data = content.data; | ||
| json.metadata = content.metadata; | ||
| json.execution_count = content.execution_count; |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
notebook implementation of jupyter/jupyter_client#209
A single display_id can be used multiple times on the page, and all instances will be updated and kept in sync.
related: ipython/ipykernel#204 , ipython/ipython#10048