fix(revenue_recovery): return actionable webhook errors - #13719
Open
NISHANTH1221 wants to merge 9 commits into
Open
fix(revenue_recovery): return actionable webhook errors#13719NISHANTH1221 wants to merge 9 commits into
NISHANTH1221 wants to merge 9 commits into
Conversation
Changed Files
|
14 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
Returns actionable responses for revenue recovery webhook failures that cannot succeed on retry.
Stack Dependency
Depends on #13718.
Additional Changes
Motivation and Context
The incoming webhook handler previously converted every revenue recovery error into a generic 5xx response. Chargebee would therefore retry malformed payloads, missing merchant configuration, and terminal invoice-state failures even though replaying the same event could not resolve them.
Mapping non-retryable failures to specific 4xx responses stops futile webhook retries and exposes the configuration or state that must be corrected. Transient failures remain retryable.
How did you test it?
cargo +nightly fmt --all -- --checkcargo check --package router --no-default-features --features release,v2,redis-rsgit diff --check origin/main..HEADValidation was run on the complete stacked branch.
Checklist
cargo +nightly fmt --allcargo clippyRelated Issue
Closes #13717