-
-
Notifications
You must be signed in to change notification settings - Fork 2
feat: implement sso auth via OIDC #2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WHY THE FUCK IS THIS NOT AUTOMATIC?!?!?!?!?!?!
changed error type from a static str to (). also simplified cookies call
oops, forgot to commit this with the other one
fixes E0195 stating the lifetimes don't match
|
was initially running into the following error during testing: doing some digging into Authentik's source code, it only signs the JWT with the client secret + HS256 algorithm when no other certificate is set. updating the provider to use "-------" as the signing key got a different error message.
the audience should just be the client id, and i double checked it's set properly. most likely this just needs to be passed to the jsonwebtoken library. |
|
had to disable alg validation to get rid of the |
changing from /api/auth/.../oidc to /auth/oidc/...
stop invading users' web browsers like a virus
|
there's still some quirks with this, e.g. client data handler errors out when a request fails due to your session expiring instead of just telling you, but improving the error handling can be done in the main branch. the core objective of this PR--implementing OIDC--is complete. 🎉 |
This PR makes the necessary changes to enable SSO authentication via OIDC.
/auth/oidc/login, users will be redirected to the OIDC provider to sign in./auth/oidc/response, from which we decode the JWT and save the claims (user data) in a cookie.Remaining Challenges:
Request::credentialsfor web emilk/ehttp#62.