Remove route-pair coercion from vhosts#196
Open
SevereOverfl0w wants to merge 1 commit into
Open
Conversation
SevereOverfl0w
added a commit
to juxt/edge
that referenced
this pull request
Apr 24, 2019
SevereOverfl0w
force-pushed
the
fixvhostscoercion
branch
from
83fffe4 to
1a1e540
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This breaks custom matchers, as mentioned in #187. #187 is not fixed by this because RoutePair generally needs fixing, but this makes it
sufficiently optional for users.