Skip to content

Add yada functionality to serve a local system directory or file #111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
luciodale wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add yada functionality to serve a local system directory or file #111

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0e83d5c
Add yada functionality to serve a local system directory or file
luciodale Oct 10, 2019
0706ee7
Update defmethod names and add docs
luciodale Nov 4, 2019
6960225
Update docs
luciodale Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions lib/edge.ig.yada/src/edge/yada/ig.clj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,16 @@
id
(assoc :id id)))

(defmethod ig/init-key ::external-directories
Copy link
Contributor

@SevereOverfl0w SevereOverfl0w Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe directory-resource is better? Then it can rely on the existing known name.

Copy link
Contributor Author

@luciodale luciodale Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't resource not ideal because the directory won't be on the classpath?

Copy link
Contributor

@SevereOverfl0w SevereOverfl0w Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Resource would refer to web resource in this context, same as in yada

[_ {:keys [path options]}]
(yada.resources.file-resource/new-directory-resource
Copy link
Contributor

@SevereOverfl0w SevereOverfl0w Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to require this namespace before using it. See requiring-resolve below.

(io/file path) (or options {})))

(defmethod ig/init-key ::external-files
Copy link
Contributor

@SevereOverfl0w SevereOverfl0w Nov 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

file-resource is perhaps better

[_ {:keys [path options]}]
(yada.resources.file-resource/new-file-resource
(io/file path) (or options {})))

(defmethod ig/init-key ::classpath-name
[_ {:keys [name]}]
(yada/as-resource (io/resource name)))
Expand Down