test(manual): add gameplay test report (#394)#421
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
✅ Code Formatting Check Passed!Great job! 🎉 Your code follows the Google Java Style Guide. 🤖 The DinoBot Team 🦖 |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @qbeck66, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with the repository
/dinosaur-explodermainbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
- ✅ Verify that you have well fill out the different checkboxes in the PR template.
⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.- 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
|
qbeck66
changed the title
Build preview 🚀Thanks for your contribution to this open-source project! ❤️ A new build has been generated for this pull request:
Tip This JAR lets you test the latest version of the game from this PR. ⏳ Note: Artifacts auto-expire after ~90 days. Happy testing & enjoy the game! 🎮 The DinoBot Team 🦖 |
|
|
||
| During longer manual testing, I noticed: | ||
|
|
||
| 1. After the player dies, there is a short delay before the game-over menu appears. During that delay, the player can still briefly move/collide with objects. |
There was a problem hiding this comment.
Hey, this was discussed to not show immediately the game over screen when player dies, but I'm sure it can be improved as the goal was to have like an animation when player dies before showing the Game Over screen. Maybe we can improve it and remove all dinosaurs I don't know (in an animated way)
| During longer manual testing, I noticed: | ||
|
|
||
| 1. After the player dies, there is a short delay before the game-over menu appears. During that delay, the player can still briefly move/collide with objects. | ||
| 2. During level transitions, dinos already on screen pause briefly before continuing. |
There was a problem hiding this comment.
Okay interesting, this is an issue indeed.
|
|
||
| 1. After the player dies, there is a short delay before the game-over menu appears. During that delay, the player can still briefly move/collide with objects. | ||
| 2. During level transitions, dinos already on screen pause briefly before continuing. | ||
| 3. One audio distortion issue happened once, but I was not able to reproduce it yet(I assume this was on my end, but I decided to still mention it here). |
There was a problem hiding this comment.
I have the same issue sometimes, you're not the only one... I have no idea how it occurs, it's like a kind of saturation? I thought it was on my Mac (idk if u have a Windows?)
jvondermarck
left a comment
jvondermarck
left a comment
There was a problem hiding this comment.
Hey @qbeck66 thanks a lot for these manual tests. Please feel free to create new issues so either "Bug" issue or a "Feature" issue to improve stuff. I don't think I will merge this PR as there isn't any added value, but we can officially close this PR when you finalized to create the different issues. What do you think?
jvondermarck
added
status: in-review
3 participants
✅ PR Checklist
Tip
Please check the boxes below to confirm you followed the contribution guidelines:
type(scope): description (#issue)(scope and #issue optional)type: feat, fix, refactor, docs, test, chore📝 What does this PR do?
🔗 Related Issue
📸 Screenshots / Demos (if applicable)
Note
🦖 No screenshots or demo provided.
💬 Extra Notes (Optional)
❤️ Thanks again for your contribution to Dinosaur Exploder!
Your efforts help make this project awesome for everyone. 🦖✨