feat(achievements): persist unlocked achievements in settings.properties#423
feat(achievements): persist unlocked achievements in settings.properties#423GVolquartsen wants to merge 1 commit into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
👋 Hello @GVolquartsen, thank you for submitting in Dinosaur Exploder 🦖 PR! To allow your work to be integrated as seamlessly as possible, we advise you to:
- ✅ Verify your PR is up-to-date with the repository
/dinosaur-explodermainbranch. If your PR is behind you can update your code by clicking the 'Update branch' button or by runninggit pullandgit merge masterlocally. - ✅ Verify all Dinosaur Exploder Continuous Integration (CI) checks are passing.
- ✅ Verify that you have well fill out the different checkboxes in the PR template.
⚠️ Check that your code is clean: no code redundancy, variable and method names are correct, your code is understandable to everyone, and so on.- 💡 Reduce changes to the absolute minimum required for your bug fix or feature addition. "It is not daily increase but daily decrease, hack away the unessential. The closer to the source, the less wastage there is." — Bruce Lee
| import java.util.stream.Collectors; | ||
| import com.dinosaur.dinosaurexploder.utils.AchievementsProvider; | ||
| import java.util.ArrayList; | ||
| import java.util.HashSet; |
There was a problem hiding this comment.
[💄Spotless - Format] reported by reviewdog 🐶
| import java.util.HashSet; |
🎨 Code Formatting Issues1 Java file(s) need formatting. 💡 Quick fixClick the suggestions below:
Or run locally: mvn spotless:apply
git add -A && git commit -m "style: apply Spotless" && git push📚 More optionsAuto-format in your IDE:
Style guide: Google Java Style Guide 🤖 The DinoBot Team 🦖 |
❌ Build FailedThanks for your contribution to this open-source project! ❤️ Unfortunately the build for this pull request has failed:
Tip Please check the logs and fix any issues before re-running the workflow. Good luck with your debugging! 🐛 (or should I say dino-bugging? 🦖) The DinoBot Team 🦖 |
jvondermarck
added
status: in-review
2 participants
📝 What does this PR do?
Fixes the issue where achievements were showing as unlocked every time the game was relaunched. The solution now persists achievement unlock status to
settings.properties, similar to how game settings are saved.Changes:
getId()andgetDescription()abstract methods toAchievementbase classsetCompleted()method to allow restoring achievement state from diskAchievementManagerto load completed achievements on startup and save when new achievements are unlockedAchievementsProviderutility class to handle reading/writing achievement data tosettings.propertiesAchievementsProviderTestto verify persistence functionalityResult: