Fix Android build failure for non-IMA users (#201) #203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Added IMA-specific advertising configuration helper in `ImaHelper.java` for managing IMA and IMA DAI ads. - Updated `RNJWPlayerAds.java` to delegate IMA configuration to `ImaHelper`. - Introduced validation in `RNJWPlayerView.java` to ensure IMA settings are not used when IMA is disabled. - Enhanced `build.gradle` to conditionally include IMA dependencies based on configuration.
- Improved validation for 'adClient' in `RNJWPlayerAds.java` to ensure it is present and not null. - Added checks for 'assetKey' and video identifiers in `ImaHelper.java` to enforce correct IMA DAI settings. - Updated ad schedule handling to return an empty list if not provided, preventing null pointer exceptions. - Enhanced error messages for better clarity on configuration issues.
- Enhanced `ImaHelper.java` to support both "adClient" and "client" keys for IMA configuration. - Updated `RNJWPlayerAds.java` to handle legacy "googima" format and added error logging for IMA configuration failures. - Introduced new methods in `RNJWPlayerView.java` to check and warn about IMA usage when IMA is disabled, improving user feedback. - Refactored advertising configuration logic to conditionally skip IMA setup based on the presence of relevant keys.
Jmilham21
changed the title
Collaborator
Author
|
Solves the build problem, and all IMA configs still work when IMA is enabled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
What does this Pull Request do?
Fixes Android build failures for non-IMA users by making the
jwplayer-imadependency truly optional through Gradle source sets.src/ima/andsrc/noima/)"client"and"adClient"property namesWhy is this Pull Request needed?
After v1.3.0, developers not using IMA ads couldn't build their apps because:
jwplayer-imawas always included (requires desugaring)This makes IMA truly optional - no IMA dependencies or desugaring required unless explicitly enabled.
Are there any points in the code the reviewer needs to double check?
android/build.gradle- verify paths are correctRNJWPlayerView.java:Are there any Pull Requests open in other repos which need to be merged with this?
No
Addresses Issue(s):
GitHub Issue #201