Open
Conversation
mskr
commented
Jun 6, 2021
mskr
commented
- async execute functions
- async undo functions
- ES6 module
- async execute functions - async undo functions - ES6 module
Author
|
@jzaefferer Can review this? |
Owner
|
The diff looks fine to me. Surely breaking changes, but that's expected. Did you check if the demos are still working with these changes? Since that's the only documentation there is, it would be helpful to keep them alive. |
jzaefferer
approved these changes
Jun 6, 2021
Author
|
Great. However I did not look at the examples yet, but agree, it would be very helpful to have them. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.