Keystone User: Mutability tests for enabled and passwordRef fields#731
Merged
mandre merged 1 commit intok-orc:mainfrom Apr 2, 2026
Merged
Keystone User: Mutability tests for enabled and passwordRef fields#731mandre merged 1 commit intok-orc:mainfrom
mandre merged 1 commit intok-orc:mainfrom
Conversation
dlaw4608
changed the title
mandre
reviewed
Apr 1, 2026
| } | ||
| } | ||
|
|
||
| func TestHandleEnableUpdate(t *testing.T) { |
Collaborator
There was a problem hiding this comment.
Nit, the field is called enabled, the function is called handleEnabledUpdate, so the function should be called TestHandleEnabledUpdate for consistency.
TestHandleEnableUpdate - Compares desired state (K8s) vs actual state (openstack) TestReconcilePassword - Uses mock openstack client and fake k8s client to verify the functions reconciliation logic that passwordReconcile reads passwords from secrets correctly, only calls UpdateUser when actually needed and tracks what password was last applied Signed-off-by: Daniel Lawton <dlawton@redhat.com>
dlaw4608
force-pushed
the
user_unit_tests
branch
from
add2a57 to
ec11043
Compare
mandre
approved these changes
Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #730
TestHandleEnableUpdate
TestReconcilePassword