fix: fail fast on deployment errors and add pyyaml dependency#24
Closed
yoavkatz wants to merge 2 commits into
Closed
fix: fail fast on deployment errors and add pyyaml dependency#24yoavkatz wants to merge 2 commits into
yoavkatz wants to merge 2 commits into
Conversation
Replace dead post-command `if [ $? -ne 0 ]` checks (killed by set -e before they run) with `|| fail "..."` pattern, and convert warnings on unexpected API responses to hard failures to avoid proceeding with a broken backend. Add pyyaml as an explicit dependency for authbridge/pipeline-merge.py. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
Closed as will be part of #27. |
github-project-automation
Bot
moved this from New/ToDo
to Done
in Kagenti Issue Prioritization
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
if [ $? -ne 0 ]checks (silently skipped underset -e) with|| fail "..."pattern acrossdeploy-and-evaluate.sh.envfiles to hard failures indeploy-benchmark.sh, preventing silent continuation with a broken backendpyyaml>=6.0as an explicit dependency forauthbridge/pipeline-merge.pywhich uses it to read/write YAML config fragmentsTest plan
deploy-and-evaluate.shagainst a healthy environment — verify all three steps complete successfullyfail "... (step N/3)"message prints and script exits non-zero.env.<benchmark>file — verify script aborts rather than deploying without env varsuv syncinexgentic_a2a_runner/— verify pyyaml installs correctly🤖 Generated with Claude Code