fixed onerror not pasing preverror and onsuccess not checking errnotfound#61
Open
encleine wants to merge 1 commit intokalbhor:mainfrom
Open
fixed onerror not pasing preverror and onsuccess not checking errnotfound#61encleine wants to merge 1 commit intokalbhor:mainfrom
encleine wants to merge 1 commit intokalbhor:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this is a small fix to 2 problems that caused a bit of confusion when I was using this package
on success not checking ErrNotFound meant I had to call save even when I don't have anything to save
and PrevErr is really helpful to be passed to onError jobs for example in cleanup jobs