Allow federation metadata & prepare lib for SWITCHAAI#1
Closed
Allow federation metadata & prepare lib for SWITCHAAI#1
Conversation
added 5 commits
June 14, 2019 15:05
For now we only logout the user from our service. We don't use so called SLO of shibboleth (that would allow us to log user out of idp and all SPs they are logged into).
kanes115
changed the title
Owner
Author
|
Closing due to #2 which is more general |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TODO:
run testsAs we got rid ofmd:prefix tests won't pass as they use the proper way of namespacingcheck that it still works with singleNot checking this as tests don't pass anywayEntityDescriptorFix the problem with xmlns as prefixThe problem is that for some reason SwitchAAI metadata file does not usemd:in some placesurn:oasis:names:tc:SAML:2.0:metadataxmlns for tags likeEntityDescriptor(it should). So we cannot really fix this. One thing we could do is to do it in a seperate PR and this way let this PR be merged to OS.