Remove leftover debug printf from EncodeManager::doUpdate#359
Closed
gaberudy wants to merge 1 commit into
Closed
Conversation
`printf("TOTAL FRAME TOOK: %d\n", ...)` runs once per frame on every
connection, spamming the kasmvncserver log/console with one line per
encode. This appears to be a debug aid left in from the VNC-151 video
encoding work — there's no flag gating it and the surrounding code uses
the project's `vlog` facility for real diagnostics.
No behavior change beyond removing the noise.
Collaborator
|
@gaberudy , thank you for identifying this. This was rolled in with a recent set of refinements and is now on master. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
printf("TOTAL FRAME TOOK: %d\n", ...)runs once per frame on every connection, spamming the kasmvncserver log/console with one line per encode. This appears to be a debug aid left in from the VNC-151 video encoding work.No behavior change beyond removing the noise.