Implement InitialGasModel => And charge signatures #23
+137
−28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goal of this PR is to charge signatures both for size and for CPU.
It will be necessary for Post-Quantum signatures.
To sanitize and make it more clear, the PR creates a new concept of InitialGasModel:
an object that summarizes how a transaction will be charged, in Chainweb, before going to Pact.
The gas models are triggered by a rule within the Version.
Note: that this is Pact 5 only... I don't see the necessity to add complexity for porting it to Pact 4.
TODO: Create some proper unit tests