Skip to content

Add Base32 conversion utilities#1

Merged
kduma merged 8 commits intomainfrom
codex/add-base32-conversion-methods-with-tests
Sep 18, 2025
Merged

Add Base32 conversion utilities#1
kduma merged 8 commits intomainfrom
codex/add-base32-conversion-methods-with-tests

Conversation

@kduma
Copy link
Contributor

@kduma kduma commented Sep 18, 2025

Summary

  • add a Base32 utility with RFC 4648-compatible encoding/decoding using the default alphabet
  • expose Base32 conversions through the BinaryString class
  • cover the new behaviour with vectors and round-trip unit tests

Testing

  • composer test (fails: phpunit binary unavailable in environment)

https://chatgpt.com/codex/tasks/task_e_68cbce3db39c8332ad7e9ef53e531fd5

@github-actions
Copy link

github-actions bot commented Sep 18, 2025

🔍 Test Results - PHP 8.4

Code Style Check Passed

Tests Failed

Some tests are failing. Please check the workflow run for details.

Code Coverage: 91.67% (Required: 100%)

Code coverage requirement not met. Please add tests to achieve 100% coverage.


This comment was automatically generated by the test workflow.

@kduma kduma requested a review from Copilot September 18, 2025 13:00
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds Base32 encoding and decoding functionality with RFC 4648 compatibility, implementing a new Base32 utility class and integrating it with the existing BinaryString class.

  • Implements a configurable Base32 encoder/decoder with default RFC 4648 alphabet
  • Adds Base32 conversion methods to BinaryString class for seamless integration
  • Provides comprehensive test coverage with RFC vectors and round-trip validation

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
src/Base32.php New utility class implementing Base32 encoding/decoding with configurable alphabet support
src/BinaryString.php Adds toBase32() and fromBase32() methods to integrate Base32 functionality
tests/Base32Test.php Comprehensive test suite covering RFC vectors, round-trip tests, and edge cases

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

kduma and others added 4 commits September 18, 2025 15:01
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ub.com:kduma-OSS/PHP-binary-tools into codex/add-base32-conversion-methods-with-tests
@kduma
Copy link
Contributor Author

kduma commented Sep 18, 2025

@codex review

@kduma kduma requested a review from Copilot September 18, 2025 14:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.


Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

kduma and others added 2 commits September 18, 2025 16:10
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@chatgpt-codex-connector
Copy link

Codex Review: Didn't find any major issues. 🎉

About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you open a pull request for review, mark a draft as ready, or comment "@codex review". If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex fix this CI failure" or "@codex address that feedback".

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kduma kduma merged commit 3b35483 into main Sep 18, 2025
1 check passed
@kduma kduma deleted the codex/add-base32-conversion-methods-with-tests branch September 18, 2025 14:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant