AI-1166: xfail AI-service integtests on CI timeouts - #533
Closed
Matovidlo wants to merge 1 commit into
Closed
Conversation
Contributor
Author
|
@claude review |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR aims to improve CI stability by tolerating intermittent AI-service read timeouts in integration tests, plus a patch version bump.
Changes:
- Adds non-strict
xfailmarkers to two AI-service integration tests. - Bumps package version from
1.61.0to1.61.1.
Reviewed changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
integtests/tools/test_search.py |
Marks test_find_component_id as expected-failable. |
integtests/tools/test_doc.py |
Marks test_docs_query as expected-failable. |
pyproject.toml |
Updates project version. |
uv.lock |
Updates locked editable package version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Matovidlo
force-pushed
the
AI-1166-xfail-ai-service-integtests
branch
from
May 18, 2026 12:46
d058b57 to
935a202
Compare
`test_find_component_id` and `test_docs_query` hit external LLM endpoints (`suggest/component`, `docs/question`) that can exceed the 60s `read` budget under CI load, surfacing as `httpx.ReadTimeout` from a single POST attempt — the retry transport in `clients/base.py` does not retry POSTs on network exceptions. `@pytest.mark.xfail(strict=False)` lets the suite pass when the service is slow while still validating correctness on healthy runs. Re-applies the same one-line markers from commit 39233cd, which lived only on a feature branch that never merged. Bumps version to 1.61.1. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Matovidlo
force-pushed
the
AI-1166-xfail-ai-service-integtests
branch
from
May 18, 2026 12:52
935a202 to
6867307
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Linear: AI-1166
Change Type
Summary
Adds
@pytest.mark.xfail(strict=False, reason='AI service may exceed read timeout in CI')to the two integtests that hit external LLM endpoints:integtests/tools/test_search.py::test_find_component_id→suggest/componentintegtests/tools/test_doc.py::test_docs_query→docs/questionBoth endpoints regularly exceed the 60s
readbudget configured inclients/base.py, surfacing ashttpx.ReadTimeout. The retry transport (httpx_retries.RetryTransport) does not retry POSTs on network exceptions by default, so a single slow upstream produces a single hard failure and blocks every unrelated PR.xfail(strict=False)lets the suite pass when the AI service is slow while still validating correctness on healthy runs — and an unexpected pass does not flip the suite to failed.This re-applies the exact one-line markers from commit
39233cd6("AI-1166: mark AI-service integration tests xfail to tolerate CI timeouts", 2026-05-12), which lived only on the still-openAI-1166-variables-supportbranch (PR #498) and so never reachedmain. Pulling the markers out into their own PR keeps that larger feature branch unrelated to a generic CI-stability fix.Version bumped 1.61.0 → 1.61.1 (patch).
Testing
Streamable-HTTPtransports)Optional testing
canary-orionMCP (Streamable-HTTP)canary-orioncanary-orionBehavioural test surface is the integtests themselves: when the AI service responds in time the tests still assert all their original invariants (component ID match, docs answer present, source URLs non-empty, TOON round-trip); when it times out,
xfail(strict=False)recordsXFAILinstead ofFAIL. Local tox checks pass:Unit tests (
tox -e python) untouched — changes are scoped tointegtests/.Checklist
🤖 Generated with Claude Code