Require storage-api-php-client-branch-wrapper ^7.0 across platform libs - #548
Merged
Conversation
… ^7.0 7.0 requires an authType whenever a Storage client is built from a token; the functional test now passes AuthType::STORAGE_TOKEN (accepted by 6.x and 7.0).
Test helpers now set AuthType::STORAGE_TOKEN on token-bearing ClientOptions (required by 7.0, accepted by 6.x). No src changes.
Test helpers now set AuthType::STORAGE_TOKEN on token-bearing ClientOptions (required by 7.0, accepted by 6.x). No src changes.
…t-branch-wrapper ^7.0 Tests set AuthType::STORAGE_TOKEN on token-bearing ClientOptions and pass the now-required AuthType to StorageApiToken. No src changes.
…er ^7.0 StorageApiToken's 3rd ctor arg (AuthType) is required in 7.0; test doubles extending the base token now pass AuthType::STORAGE_TOKEN. No src changes.
StorageApiAwareTrait now sets AuthType::STORAGE_TOKEN on its ClientOptions (7.0 requires an authType when a token is set).
janvanicek
approved these changes
Jul 23, 2026
janvanicek
left a comment
janvanicek
left a comment
Contributor
There was a problem hiding this comment.
Ok, jen to BQ mrkni na CI
… changedSince message) Two functional assertions were stale on main, surfaced here because the branch-wrapper bump runs input-mapping's functional suite: - testTablesBigQueryBackend expected loadType VIEW, but AJDA-2841 (already on main) delegates the workspace load-type decision to the endpoint, which now returns CLONE for BigQuery. - testDownloadTablesInvalidDate asserted the old Storage API validation message; the server now returns 'Invalid request: ...' so the assertion matches the stable core text.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release Notes
Driver: https://linear.app/keboola/issue/PAT-1960/runner-sync-api-migrate-custom-runid-generator-to-api-bundle-60-config
Note
Bump client wrapper lib dependency na movou major verzi
Moves the platform libraries that depend on
keboola/storage-api-php-client-branch-wrapperto require^7.0, so downstream services (starting withrunner-sync-api, PAT-1960) can adopt branch-wrapper 7.0 + api-bundle 6.1. branch-wrapper 7.0's only breaking changes are:ClientOptions::getClientConstructOptions()now throws when a token is set without anauthType,StorageApiToken's 3rd constructor arg (AuthType) is now required, and the removal ofFactory\StorageClientRequestFactory/ClientOptions::runIdGenerator(unused by these libs).Every library's production
src/was already compatible — the only production change isphp-test-utils'StorageApiAwareTrait, which now setsAuthType::STORAGE_TOKENon itsClientOptions. Everything else is test fixtures that construct a token-bearingClientOptions(or a baseStorageApiToken) now explicitly passingAuthType::STORAGE_TOKEN— accepted by both 6.x and 7.0, so the change is not runtime-behaviour-affecting.Libraries bumped (one commit each):
staging-provider,input-mapping,output-mapping,configuration-variables-resolver,permission-checker,php-test-utils.Verified locally against branch-wrapper 7.0:
composer phpstan(coverssrc+tests) andphpcsgreen for all six;permission-checkerunit tests green (193). The credential-backed functional suites (input/output-mapping, staging-provider, configuration-variables-resolver) run in CI.Plans for customer communication
None.
Impact analysis
Consumers of these libraries move to branch-wrapper
^7.0when they pick up the new minor releases; runId/auth behaviour is unchanged. The constraint is strict^7.0(drops^6.0), so a consumer still pinning branch-wrapper 6.x must upgrade — this is the intended platform-wide move to 7.0. No end-user (runtime) impact.Change type
Maintenance
Justification
Roll
storage-api-php-client-branch-wrapper7.0 through the platform libraries so downstream services can migrate (unblocks PAT-1960 / runner-sync-api).Deployment
Merge & automatic deploy.
Rollback plan
Revert of this PR.
Post release support plan
None.