devise for user authentication and paperclip for avatar#21
Open
ashishrudra wants to merge 3 commits intokeep-delivering:masterfrom
Open
devise for user authentication and paperclip for avatar#21ashishrudra wants to merge 3 commits intokeep-delivering:masterfrom
ashishrudra wants to merge 3 commits intokeep-delivering:masterfrom
Conversation
ashishrudra
commented
Sep 12, 2015

Contributor
There was a problem hiding this comment.
We're going to have to configure a Heroku-compatible email method.
Contributor
|
Good start! Looks like you need to work these changes into current master, though. |
Author
|
it's an alternative of twitter authentication. I think we need to choose one of them. |
dce97d8 to
d90ca41
Compare
Contributor
|
I believe Devise supports omniauth, i.e. Twitter. |
Contributor
|
Talked with @ashishrudra offline about this. I'm not opposed to dropping Twitter support for a more standard login approach, but I see much more work ahead of us with this approach:
Plus I hear we may be able to require emails with our existing omniauth approach, which I think is key to either approach. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.