fix(hive): emit the wire symbols hived uses, not the display ones

[BitHighlander]

The bug

hived encodes HIVE as STEEM and HBD as SBD. The 2020 rebrand renamed the tokens but not their on-chain serialization. asset() wrote the display spelling, so the device signed bytes hived never reproduces. hived re-serializes the operation to check the signature, recovers a key from different bytes, finds it in no authority, and reports:

missing required active authority: Missing Active Authority <account>
Transaction failed to validate using both new (hf26) and legacy serialization

Found in live testing on a limit_order_create; the message points at keys and the keys were fine.

Scope: every asset-bearing op here — transfer_to_vesting, convert, comment_options, transfer_to_savings, transfer_from_savings, claim_reward_balance, limit_order_create. Not vote / comment / custom_json (no assets), not the VESTS-only ops (VESTS is spelled the same), and not hive_transfer (firmware builds those bytes from typed fields, never through this serializer) — which is why voting and transfers worked.

The fix

One line in asset(): write WIRE_SYMBOL[symbol] ?? symbol. Input parsing, precision rules and the symbol whitelist still speak in display symbols, so callers and error messages are unchanged.

Why the tests didn't catch it

They were byte-exact mirrors of the firmware parser, which expected the same wrong bytes. Two independent implementations of the same misunderstanding is not verification.

Added two golden vectors from hived's own condenser_api.get_transaction_hex (limit_order_create and claim_reward_balance, covering all three symbols), compared against the full serializer output. They drop hived's trailing signatures-count byte, since the digest preimage stops after the extensions varint.

57/57 pass.

Ships with

BitHighlander/keepkey-firmware#316 — the parser has to accept STEEM/SBD and map back to HIVE/HBD for the OLED. Merging this alone makes the device reject every asset-bearing op.

🤖 Generated with Claude Code