fix: reject overlong UTXO swap memos before signing#379
Merged
Conversation
BitHighlander
marked this pull request as ready for review
July 24, 2026 20:13
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OP_RETURN, 250 bytes elsewhereRoot cause
Vault enforced only THORChain's global 250-byte memo limit, while the current KeepKey UTXO signer supports a single 80-byte
OP_RETURN. A full contract-qualified BTC → USDT memo therefore passed quote parsing and preview, then failed late during signing.User impact
Unbuildable UTXO routes now fail or fall through before the confirmation screen. No quoted memo is rewritten client-side; Pioneer remains responsible for constructing the compact protocol memo.
Validation
bun test __tests__/swap-parsing.test.ts— 55 passedbunx vite build— passedgit diff --check— passedThe repository-wide TypeScript check remains red on the existing baseline of unrelated errors; filtering its output to the touched files showed no new error at the changed lines.