Skip to content

Pass context when calling Postmark API#26

Open
byamba-tumurkhuu wants to merge 1 commit intokeighl:masterfrom
byamba-tumurkhuu:context
Open

Pass context when calling Postmark API#26
byamba-tumurkhuu wants to merge 1 commit intokeighl:masterfrom
byamba-tumurkhuu:context

Conversation

@byamba-tumurkhuu
Copy link
Copy Markdown

@byamba-tumurkhuu byamba-tumurkhuu commented Jul 7, 2020

@keighl I added client methods that accept context.Context as a parameter. This is helpful when you want to have chained http transports that use the original request context to do things like tracing and logging.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 7, 2020

Codecov Report

Merging #26 into master will increase coverage by 0.37%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #26      +/-   ##
==========================================
+ Coverage   97.56%   97.93%   +0.37%     
==========================================
  Files          10       10              
  Lines         410      484      +74     
==========================================
+ Hits          400      474      +74     
  Misses          5        5              
  Partials        5        5              
Impacted Files Coverage Δ
bounce.go 97.36% <100.00%> (+0.49%) ⬆️
email.go 100.00% <100.00%> (ø)
messages_inbound.go 100.00% <100.00%> (ø)
messages_outbound.go 100.00% <100.00%> (ø)
postmark.go 76.47% <100.00%> (ø)
sender_signatures.go 100.00% <100.00%> (ø)
server.go 100.00% <100.00%> (ø)
servers.go 100.00% <100.00%> (ø)
stats.go 100.00% <100.00%> (ø)
templates.go 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 28358b1...80af7b8. Read the comment docs.

Comment thread bounce.go Outdated
@byamba-tumurkhuu
Copy link
Copy Markdown
Author

Bump @keighl

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants