Regenerate with frame pointer omitted

[kelindar]

Regenerated arm64 assembly with -fomit-frame-pointer. Should fix #43

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the ARM64 assembly files (simd_apple.s and simd_neon.s) by regenerating them with the -fomit-frame-pointer compiler flag. This optimization removes frame pointer setup and teardown instructions, resulting in slightly smaller and potentially faster code. The change specifically targets and resolves a previously identified issue where frame pointers were unnecessarily included.

Highlights

• Assembly Regeneration: Regenerated ARM64 assembly code for simd_apple.s and simd_neon.s.
• Optimization: Omitted frame pointers (-fomit-frame-pointer) in the regenerated assembly, leading to potentially smaller and faster code.
• Bug Fix: Addressed and fixed issue Occasional panics on arm64 CPUs #43, which was related to the previous ARM64 assembly generation.

Changelog

• simd_apple.s
  • Removed frame pointer setup and teardown instructions from all functions.
  • Adjusted stack offsets and branch targets in various functions due to instruction removals.
  • Modified the _count function's zero-size handling to directly store zero and return, optimizing this specific case.
• simd_neon.s
  • Removed frame pointer setup and teardown instructions from all functions.
  • Adjusted stack offsets and branch targets in various functions due to instruction removals.
  • Modified the _count function's zero-size handling to directly store zero and return, optimizing this specific case.

Ignored Files

• Ignored by pattern: .github/workflows/** (1)
  • .github/workflows/test.yml

Activity

• Author regenerated ARM64 assembly with the -fomit-frame-pointer flag.
• The change is intended to fix issue Occasional panics on arm64 CPUs #43, as noted in the pull request description.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request regenerates the arm64 assembly code for both Apple and NEON targets with the -fomit-frame-pointer flag. The changes correctly remove the function prologue and epilogue instructions related to setting up and tearing down the stack frame pointer (x29). Consequently, stack allocations and branch offsets have been adjusted. These modifications are consistent with the stated goal of fixing an iOS-related crash and should also provide a minor performance improvement. The changes appear to be correct and are confined to auto-generated assembly files.