Skip to content

Update dependencies#45

Merged
kelindar merged 1 commit intomainfrom
deps
Mar 7, 2026
Merged

Update dependencies#45
kelindar merged 1 commit intomainfrom
deps

Conversation

@kelindar
Copy link
Owner

@kelindar kelindar commented Mar 7, 2026

No description provided.

@gemini-code-assist
Copy link

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on modernizing the project's development environment and external library usage. By upgrading the Go language version and its core dependencies, the project benefits from enhanced performance, security, and access to the latest features. Additionally, minor refinements were made to the code generation script and a test file to improve maintainability and clarity.

Highlights

  • Go Version Update: The project's Go language version has been upgraded from 1.18 to 1.24.0, ensuring compatibility with the latest language features and improvements.
  • Dependency Updates: Several key Go module dependencies, including github.com/kelindar/simd, github.com/klauspost/cpuid/v2, github.com/stretchr/testify, and golang.org/x/sys, have been updated to their latest versions.
  • Code Generation Script Refinement: The codegen/generate.sh script was updated to simplify gocc command calls by removing the ./bin/ prefix and now includes a helpful comment for installing gocc.
  • Test Code Cleanup: An unnecessary return statement was removed from a benchmark function in range_test.go, improving code clarity.
Changelog
  • codegen/generate.sh
    • Removed the ./bin/ prefix from gocc commands.
    • Added a comment explaining how to install gocc.
  • go.mod
    • Updated Go version from 1.18 to 1.24.0.
    • Updated github.com/kelindar/simd from v1.1.2 to v1.2.0.
    • Updated github.com/klauspost/cpuid/v2 from v2.2.4 to v2.3.0.
    • Updated github.com/stretchr/testify from v1.8.2 to v1.11.1.
    • Updated golang.org/x/sys from v0.0.0-20220704084225-05e143d24a9e to v0.41.0.
  • go.sum
    • Updated checksums for all modified dependencies.
    • Removed outdated checksum entries.
  • range_test.go
    • Removed an unnecessary return statement from the BenchmarkRange function.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@kelindar kelindar merged commit bfabcc8 into main Mar 7, 2026
1 check passed
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Go version and several dependencies. It also includes a change to the code generation script to use gocc from the system path instead of a local binary. I've suggested an improvement to the script to use go run, which makes it more self-contained and removes the need for developers to manually install gocc. The other changes look good.

Comment on lines +3 to +8
# requires gocc: go install github.com/kelindar/gocc/cmd/gocc@latest

gocc simd_avx.c --arch avx2 -O1 --package bitmap -o ../
gocc simd_avx512.c --arch avx512 -O3 --package bitmap -o ../
gocc simd_neon.c --arch neon -O3 --package bitmap -o ../
gocc simd_apple.c --arch apple -O3 --package bitmap -o ../ No newline at end of file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

To improve the developer experience and ensure the correct version of gocc is used without requiring manual installation, it's better to use go run. This command will download and run the tool automatically. I've also added set -e to make the script exit immediately if a command fails, which is a good practice for shell scripts.

Suggested change
# requires gocc: go install github.com/kelindar/gocc/cmd/gocc@latest
gocc simd_avx.c --arch avx2 -O1 --package bitmap -o ../
gocc simd_avx512.c --arch avx512 -O3 --package bitmap -o ../
gocc simd_neon.c --arch neon -O3 --package bitmap -o ../
gocc simd_apple.c --arch apple -O3 --package bitmap -o ../
# Use go run to execute gocc, making the script self-contained.
set -e
go run github.com/kelindar/gocc/cmd/gocc@latest simd_avx.c --arch avx2 -O1 --package bitmap -o ../
go run github.com/kelindar/gocc/cmd/gocc@latest simd_avx512.c --arch avx512 -O3 --package bitmap -o ../
go run github.com/kelindar/gocc/cmd/gocc@latest simd_neon.c --arch neon -O3 --package bitmap -o ../
go run github.com/kelindar/gocc/cmd/gocc@latest simd_apple.c --arch apple -O3 --package bitmap -o ../

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant