Fix update check and setup image after wesm -> kenn-io rename#368
Merged
Conversation
The updater pointed githubLatestReleaseURL and githubReleaseDownloadBase at github.com/wesm/msgvault. After the repo moved to the kenn-io org, GitHub answers /wesm/msgvault/releases/latest with a repo-rename 301 to /kenn-io/msgvault/releases/latest. resolveLatestTag uses http.ErrUseLastResponse, so it captures that first 301 instead of the /releases/latest -> /releases/tag/<tag> 302 and rejects it with "unexpected redirect target". Point both constants at github.com/kenn-io/msgvault and add a guard test that fails if these URLs drift from the canonical repo again. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The setup command generated a docker-compose.yml referencing ghcr.io/wesm/msgvault:latest, but CI publishes the image to ghcr.io/kenn-io/msgvault (IMAGE_NAME is github.repository). After the org rename that path is stale, so Docker/NAS deploys from `msgvault setup` pulled the wrong image. Update the generated image and its test. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
roborev: Combined Review (
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
After the repository moved from the
wesmorg tokenn-io, two hardcodedreferences to the old org broke at runtime.
msgvault updatefailed withunexpected redirect target. The updater'srelease URLs still pointed at
github.com/wesm/msgvault, so GitHub'srepo-rename redirect was rejected before the release tag could be resolved.
The URLs now point at
github.com/kenn-io/msgvault, and a guard test failsif they drift from the canonical repo again.
msgvault setupgenerated adocker-compose.ymlreferencingghcr.io/wesm/msgvault:latest, but CI publishes the image toghcr.io/kenn-io/msgvault. Docker/NAS deploys fromsetupnow reference thecurrent image.
🤖 Generated with Claude Code