Extract addDefuddleRules for standalone TurndownService usage#190
Open
shfshanyue wants to merge 1 commit intokepano:mainfrom
Open
Extract addDefuddleRules for standalone TurndownService usage#190shfshanyue wants to merge 1 commit intokepano:mainfrom
shfshanyue wants to merge 1 commit intokepano:mainfrom
Conversation
- Introduced addDefuddleRules to register custom rules for TurndownService. - Updated createMarkdownContent to utilize addDefuddleRules. - Exported addDefuddleRules from index.full.ts for external use. - Added tests for addDefuddleRules to ensure proper functionality.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extract Turndown rule registration logic into a standalone addDefuddleRules(turndownService) function, allowing users to apply Defuddle's custom markdown rules to their own TurndownService instances with custom options.
Previously, the only way to get Defuddle's markdown rules was through createMarkdownContent. This change enables consumers to bring their own TurndownService configuration (e.g., headingStyle: 'setext', bulletListMarker: '*') while still leveraging Defuddle's rule set.