-
Notifications
You must be signed in to change notification settings - Fork 0
Add --proxy flag for routing the browser through a Kernel proxy #56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| import Kernel, { NotFoundError } from "@onkernel/sdk"; | ||
| import { describe, expect, it } from "vitest"; | ||
| import { resolveProxyId } from "../src/harness-browser"; | ||
|
|
||
| const notFound = () => new NotFoundError(404, { message: "not found" }, "not found", new Headers()); | ||
|
|
||
| function fakeClient(overrides: { | ||
| retrieve?: (id: string) => Promise<{ id?: string }>; | ||
| list?: () => Promise<Array<{ id?: string; name?: string }>>; | ||
| }): Kernel { | ||
| return { | ||
| proxies: { | ||
| retrieve: overrides.retrieve ?? (async () => Promise.reject(notFound())), | ||
| list: overrides.list ?? (async () => []), | ||
| }, | ||
| } as unknown as Kernel; | ||
| } | ||
|
|
||
| describe("resolveProxyId", () => { | ||
| it("returns the id when the selector is an existing proxy id", async () => { | ||
| const client = fakeClient({ retrieve: async (id) => ({ id }) }); | ||
| await expect(resolveProxyId(client, "proxy_abc")).resolves.toBe("proxy_abc"); | ||
| }); | ||
|
|
||
| it("falls back to a unique name match from the proxy list", async () => { | ||
| const client = fakeClient({ list: async () => [{ id: "proxy_1", name: "residential-us" }, { id: "proxy_2", name: "other" }] }); | ||
| await expect(resolveProxyId(client, "residential-us")).resolves.toBe("proxy_1"); | ||
| }); | ||
|
|
||
| it("rejects an ambiguous name instead of guessing", async () => { | ||
| const client = fakeClient({ list: async () => [{ id: "proxy_1", name: "us" }, { id: "proxy_2", name: "us" }] }); | ||
| await expect(resolveProxyId(client, "us")).rejects.toThrow(/ambiguous/); | ||
| }); | ||
|
|
||
| it("never auto-creates: an unknown selector is an error", async () => { | ||
| const client = fakeClient({}); | ||
| await expect(resolveProxyId(client, "does-not-exist")).rejects.toThrow(/was not found/); | ||
| }); | ||
|
|
||
| it("propagates non-404 lookup failures", async () => { | ||
| const client = fakeClient({ | ||
| retrieve: async () => Promise.reject(new Error("boom")), | ||
| }); | ||
| await expect(resolveProxyId(client, "proxy_abc")).rejects.toThrow(/looking up proxy/); | ||
| }); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retrieve success falls through names
Medium Severity
In
resolveProxyId, whenproxies.retrievesucceeds but the response has no truthyid, resolution continues as if the lookup failed and tries a name match viaproxies.list(). That can route the browser through the wrong proxy or report not found even though retrieve succeeded.Reviewed by Cursor Bugbot for commit 8d6d83b. Configure here.