fix: select existing tag name in langtag canonicalization #313
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem description in #312; this fix just uses the existing langtags name rather than the name from the .keyboard_info, which could vary. The name is used only as a display name, not a search name, so no searching will be impacted. It is possible that a different name may be selected as representative, but that is probably better because we should be using langtags.json for language names in most contexts anyway. Fixes: #312
User Test ResultsTest specification and instructions User tests are not required |
mcdurdin
deleted the
fix/312-select-first-matching-language-in-langtag-canonicalization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem description in #312; this fix just uses the existing langtags name rather than the name from the .keyboard_info, which could vary. The name is used only as a display name, not a search name, so no searching will be impacted. It is possible that a different name may be selected as representative, but that is probably better because we should be using langtags.json for language names in most contexts anyway.
Fixes: #312
Test-bot: skip