Support cron scheduling via GCP Cloud Scheduler#107
Open
MohamedBeydoun wants to merge 9 commits intokeypup-io:masterfrom
Open
Support cron scheduling via GCP Cloud Scheduler#107MohamedBeydoun wants to merge 9 commits intokeypup-io:masterfrom
MohamedBeydoun wants to merge 9 commits intokeypup-io:masterfrom
Conversation
|
I think this would be a great addition to the project. Any suggestions on when/if this will be merged? |
Author
Not sure tbh 🤷 Waiting for @alachaum's review 👀 |
|
I see. @alachaum Is there any help that we can provide to get this PR merged? 🤝 |
|
@alachaum |
|
@MohamedBeydoun great work. I would also love to see this merged 💖 We might improve our chances when you would also add some documentation to the, already very good, Readme of this project :) |
|
Would love to use this as well. @alachaum is there anything we can do to help get this merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For: #20
Added GCP Cloud Scheduler support for cron job scheduling. I followed the linked issue and @ceritium's PR while also adding basic ActiveJob and OIDC support. Let me know what you think!
Testing
CloudScheduler::Manageras follows:Manager.synchronize!will sync your GCP project's Cloud Scheduler jobs with whatever you have in the config file. It will create any jobs that you add, update stale jobs, and delete any jobs that you remove.I didn't add a rake task since I wanted to give the end users the freedom to use the manager however they see fit. Let me know if you want me to add it back.
Thanks!