Task #1. User created. Integration test passed. All entities mindless…#9
Open
Eugeny2019 wants to merge 6 commits intodevelopmentfrom
Open
Task #1. User created. Integration test passed. All entities mindless…#9Eugeny2019 wants to merge 6 commits intodevelopmentfrom
Eugeny2019 wants to merge 6 commits intodevelopmentfrom
Conversation
…ly copied from Cat.
SKuznet
requested changes
Jun 5, 2019
| @RequestMapping("/") | ||
| public String getHelloPage() { | ||
| return "cat"; | ||
| return "users"; |
Collaborator
There was a problem hiding this comment.
add separate mapping for your .jsp
Collaborator
Author
There was a problem hiding this comment.
fixed. added /users
|
|
||
| @Controller | ||
| @RequestMapping("/users") | ||
| // localhost:8080/user |
Collaborator
Author
There was a problem hiding this comment.
fixed. // localhost:8080/user removed
| public class User { | ||
| @Id | ||
| @GeneratedValue(strategy = GenerationType.AUTO) | ||
| @Column(name = "id") |
Collaborator
Author
There was a problem hiding this comment.
removed. Field "login" is unique
| <tr> | ||
| <td>add new user - <code><strong>POST</strong></code></td> | ||
| <td>/users/add</td> | ||
| <> |
| User receivedUser = responseEntity.getBody(); | ||
| Assert.assertNotNull(receivedUser); | ||
|
|
||
| // update cat |
|
|
||
| @Test | ||
| public void checkGettingAllUsers() { | ||
| // add h2db - before test clean all db data |
| user.setFunction("spec"); | ||
| return user; | ||
| } | ||
|
|
# Conflicts: # src/main/java/io/khasang/pm/config/AppConfig.java
SKuznet
approved these changes
Jun 12, 2019
SKuznet
requested changes
Jun 12, 2019
Collaborator
SKuznet
left a comment
SKuznet
left a comment
There was a problem hiding this comment.
why in pull requests included java classes not related with this task - employee???
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ly copied from Cat.