Made sure apportionment works with non-consecutive list/candidate numbers#2807
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2807 +/- ##
==========================================
+ Coverage 91.60% 91.64% +0.04%
==========================================
Files 389 389
Lines 18716 18809 +93
Branches 2048 2048
==========================================
+ Hits 17144 17238 +94
+ Misses 1470 1469 -1
Partials 102 102 ☔ View full report in Codecov by Sentry. |
d00302c to
b527a0c
Compare
7b9e8a3 to
3259c74
Compare
e5a5cb2 to
454cd2d
Compare
b7bd452 to
2bcdcff
Compare
b527a0c to
715a590
Compare
bc82ce8 to
20e53db
Compare
Sigrid maintainability feedbackShow detailsSigrid compared your code against the baseline of 2026-02-09. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
20e53db to
510ca9b
Compare
Re-added removed spaces in docstring (fmt is too strict here)
…consecutive-political-group-numbers
stacktraceghost
left a comment
There was a problem hiding this comment.
I think we could add some tests that are meant to explicitly test non-consecutive numbers
I adapted some existing tests to have non-consecutive numbers instead, do you think it's better to add some more tests? |
I'd prefer to have an explicit test for it, otherwise there is a chance we lose this coverage if those tests get adjusted in the future. |
…consecutive-political-group-numbers
PDF Diff SummaryComparing against base branch:
|
Resolves #2785