-
-
Notifications
You must be signed in to change notification settings - Fork 28
Integrate the deno workflow and the compile checks #21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
tcely
wants to merge
81
commits into
kikkia:master
Choose a base branch
from
tcely:tcely-ejs-and-deno-workflow
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Patching ejs is no longer needed with the imports defined in `deno.json` - The compiler options allow including the worker
- Specify Debian for builder - Use `tini` for proper signals - Create appropriate cache directories
Fixes from building the branch
All the other images used are on 13 now anyway. Also, use the debug tag so that busybox is included. We can use that to run shell commands to avoid issues with COPY.
10985c7 to
ae96b34
Compare
ae96b34 to
f18dab8
Compare
5d8cd5a to
0be2f1d
Compare
0be2f1d to
10fe855
Compare
Refactor cache_prefix initialization to handle different environment variables more clearly.
340eb7c to
6865cc6
Compare
6865cc6 to
9040173
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement, Tests
Description
Migrate to JSR imports and Deno configuration management
deno.jsonmappingsModernize codebase with comprehensive formatting and linting
deno fmtacross all TypeScript filesEnhance player cache with robustness improvements
Simplify build process and remove workarounds
patch-ejs.tsscript (no longer needed with JSR imports)tinifor proper signal handling in containersDiagram Walkthrough
File Walkthrough
1 files
Remove EJS patching script8 files
Update imports and add timestamp loggingUpdate to JSR cache importUpdate to JSR prometheus importImplement atomic writes and in-flight deduplicationUpdate EJS import pathRemove unused imports and add linting directivesAdd crypto import and utility functionsUpdate EJS import and normalize quotes9 files
Format code and improve readabilityFormat response headers and error handlingFormat code and normalize string quotesFormat and reorder importsFormat and normalize string quotesNormalize string quotesNormalize string quotesFormat code and improve validation logicFormat and add timestamp logging1 files
Create Deno CI/CD workflow3 files
Add submodule checkout to build workflowModernize with Debian13 and tini initCreate Deno configuration with JSR imports1 files
Simplify setup instructions