-
Notifications
You must be signed in to change notification settings - Fork 160
Toml-related crates upgrades #915
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
src/lib.rs
Outdated
| pub use manifest::{find, get_dep_version, set_dep_version, LocalManifest, Manifest}; | ||
| pub use metadata::manifest_from_pkgid; | ||
| pub use registry::registry_url; | ||
| pub use toml_edit; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As this crate is not meant to be used as a library (see semver compatibility](https://docs.rs/cargo-edit/latest/cargo_edit/#semver-compatibility), I would prefer this to be reverted
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fair enough, I've dropped commit acb2f2b.
848f353 to
2ec18f5
Compare
|
As I mentioned, we do not support using this is a library, so my main interest in moving this forward is bug fixes like
See https://github.com/toml-rs/toml/blob/main/crates/toml_edit/CHANGELOG.md |
|
I'm not sure I follow your comment about |
I was stating the primary motivation to move forward with this PR. I'll handle the changelog when releasing. |
I'm using
cargo-edit(0.13.0) as a library in one of my projects in addition tocargo_toml(0.21.0). Sincecargo-editdepends on "old" versions of some crates (toml0.7.6 andtoml_edit0.19.14) andcargo_toml0.21.0 depends ontoml0.8.14, cargo pulls in multiple versions of them in the dependency tree.This PR simply bumps the
tomlandtoml_editto their latest released versions. The[dev-dependency]trycmdis also upgraded since it has a direct dependency ontoml_edit. The lock file is updated too following those upgrades.Note also that I added a re-export of
toml_editsince some of its types appear in the public API, for example incargo_edit::Manifest. Doing so allows end-user to not have to addtoml_editto their own[dependency].