Skip to content

fix: wait to show goal information until yearly data loads#6689

Merged
christian14b merged 3 commits intomainfrom
MP-2542--fix-goal-target-changes-on-page-load
Mar 3, 2026
Merged

fix: wait to show goal information until yearly data loads#6689
christian14b merged 3 commits intomainfrom
MP-2542--fix-goal-target-changes-on-page-load

Conversation

@christian14b
Copy link
Copy Markdown
Collaborator

@christian14b christian14b commented Mar 2, 2026

https://kiva.atlassian.net/browse/MP-2542

Found this weird state, while working on goal-setting (See video attached in ticket)

Add a loading state when goal data information (progress ring) is still fetching..

Screen.Recording.2026-03-02.at.10.25.50.AM.mov

@christian14b christian14b requested a review from a team March 2, 2026 15:26
@christian14b christian14b added the b2c Sends B2C team a message in Slack on PR creation label Mar 2, 2026
@roger-in-kiva
Copy link
Copy Markdown
Collaborator

Is this only happening in /goal-setting page? Just wondering if could/should be added to this loading state:

@christian14b
Copy link
Copy Markdown
Collaborator Author

christian14b commented Mar 2, 2026

Is this only happening in /goal-setting page? Just wondering if could/should be added to this loading state:

Yes, in kiva card seems to be handled different. In Goal Settings, there is a loader for the goal options, but no for the ring progress. The issue happens because ProgressRing renders when userGoal is set but the yearly progress data is not yet completed

@roger-in-kiva
Copy link
Copy Markdown
Collaborator

Do we need some fix here?

@christian14b
Copy link
Copy Markdown
Collaborator Author

Do we need some fix here?

Is this the card in MyKiva? If so, the loading state works there because of the loading value. I validated the page with this changes.

In Goal Setting, there's no loading state for the progress ring while yearly data is still fetching

Comment thread src/components/MyKiva/GoalProgressRing.vue Outdated
Comment thread src/components/MyKiva/GoalProgressRing.vue Outdated
@christian14b
Copy link
Copy Markdown
Collaborator Author

Do we need some fix here?

Although, there's a bug ticket related to a missmatch in goal data between this card an goal setting. So it's probably related.

@dyersituations
Copy link
Copy Markdown
Collaborator

@christian14b there is indeed a bug ticket, but it's related to /goal-setting, so I think your new ticket is a duplicate. The bug was that /goal-setting showed the correct number, and it changed to an incorrect number after a few moments. It looks like this fix would actually hide the real issue, correct?

Comment thread src/components/MyKiva/GoalProgressRing.vue Outdated
@christian14b
Copy link
Copy Markdown
Collaborator Author

@christian14b there is indeed a bug ticket, but it's related to /goal-setting, so I think your new ticket is a duplicate. The bug was that /goal-setting showed the correct number, and it changed to an incorrect number after a few moments. It looks like this fix would actually hide the real issue, correct?

Yes! But I thought I saw a ticket related to the goal target being different between this page and my kiva. Let me double check

Comment thread src/components/MyKiva/GoalProgressRing.vue Outdated
Comment thread src/components/GoalSetting/GoalSettingContainer.vue Outdated
Comment thread src/components/MyKiva/GoalSetting/GoalSelector.vue
Comment thread src/components/MyKiva/GoalSetting/GoalSelector.vue
@christian14b christian14b merged commit 3bcae30 into main Mar 3, 2026
5 checks passed
@christian14b christian14b deleted the MP-2542--fix-goal-target-changes-on-page-load branch March 3, 2026 14:07
@kiva-robot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.59.0-rc.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@kiva-robot
Copy link
Copy Markdown
Collaborator

🎉 This PR is included in version 3.59.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

b2c Sends B2C team a message in Slack on PR creation released on @staging released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants