Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -188,7 +188,7 @@ lint: $(BUILD_DIRS)
--env GO111MODULE=on \
--env GOFLAGS="-mod=vendor" \
$(BUILD_IMAGE) \
golangci-lint run --enable $(ADDTL_LINTERS) --timeout=10m --skip-files="generated.*\.go$\" --skip-dirs-use-default
golangci-lint run --enable $(ADDTL_LINTERS) --timeout=10m --exclude-files="generated.*\.go$\" --exclude-dirs-use-default

$(BUILD_DIRS):
@mkdir -p $@
Expand Down
2 changes: 0 additions & 2 deletions acme/v1/challenge.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func TryUpdateChallenge(ctx context.Context, c cs.AcmeV1Interface, meta metav1.O
klog.Errorf("Attempt %d failed to update Challenge %s/%s due to %v.", attempt, cur.Namespace, cur.Name, e2)
return false, nil
})

if err != nil {
err = errors.Errorf("failed to update Challenge %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down Expand Up @@ -143,7 +142,6 @@ func UpdateChallengeStatus(
}
return e2 == nil, nil
})

if err != nil {
err = fmt.Errorf("failed to update status of Challenge %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down
2 changes: 0 additions & 2 deletions acme/v1/order.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func TryUpdateOrder(ctx context.Context, c cs.AcmeV1Interface, meta metav1.Objec
klog.Errorf("Attempt %d failed to update Order %s/%s due to %v.", attempt, cur.Namespace, cur.Name, e2)
return false, nil
})

if err != nil {
err = errors.Errorf("failed to update Order %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down Expand Up @@ -143,7 +142,6 @@ func UpdateOrderStatus(
}
return e2 == nil, nil
})

if err != nil {
err = fmt.Errorf("failed to update status of Order %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down
2 changes: 0 additions & 2 deletions certmanager/v1/certificate.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func TryUpdateCertificate(ctx context.Context, c cs.CertmanagerV1Interface, meta
klog.Errorf("Attempt %d failed to update Certificate %s/%s due to %v.", attempt, cur.Namespace, cur.Name, e2)
return false, nil
})

if err != nil {
err = errors.Errorf("failed to update Certificate %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down Expand Up @@ -143,7 +142,6 @@ func UpdateCertificateStatus(
}
return e2 == nil, nil
})

if err != nil {
err = fmt.Errorf("failed to update status of Certificate %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down
2 changes: 0 additions & 2 deletions certmanager/v1/certificaterequest.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func TryUpdateCertificateRequest(ctx context.Context, c cs.CertmanagerV1Interfac
klog.Errorf("Attempt %d failed to update CertificateRequest %s/%s due to %v.", attempt, cur.Namespace, cur.Name, e2)
return false, nil
})

if err != nil {
err = errors.Errorf("failed to update CertificateRequest %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down Expand Up @@ -143,7 +142,6 @@ func UpdateCertificateRequestStatus(
}
return e2 == nil, nil
})

if err != nil {
err = fmt.Errorf("failed to update status of CertificateRequest %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down
1 change: 0 additions & 1 deletion certmanager/v1/clusterissuer.go
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,6 @@ func TryUpdateClusterIssuer(ctx context.Context, c cs.CertmanagerV1Interface, me
klog.Errorf("Attempt %d failed to update ClusterIssuer %s due to %v.", attempt, cur.Name, e2)
return false, nil
})

if err != nil {
err = errors.Errorf("failed to update ClusterIssuer %s after %d attempts due to %v", meta.Name, attempt, err)
}
Expand Down
2 changes: 0 additions & 2 deletions certmanager/v1/issuer.go
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@ func TryUpdateIssuer(ctx context.Context, c cs.CertmanagerV1Interface, meta meta
klog.Errorf("Attempt %d failed to update Issuer %s/%s due to %v.", attempt, cur.Namespace, cur.Name, e2)
return false, nil
})

if err != nil {
err = errors.Errorf("failed to update Issuer %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down Expand Up @@ -143,7 +142,6 @@ func UpdateIssuerStatus(
}
return e2 == nil, nil
})

if err != nil {
err = fmt.Errorf("failed to update status of Issuer %s/%s after %d attempts due to %v", meta.Namespace, meta.Name, attempt, err)
}
Expand Down
Loading