Skip to content

Add api-group to distinguish virtual secret #125

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
HiranmoyChowdhury wants to merge 1 commit into from
Closed

Add api-group to distinguish virtual secret #125

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 9 additions & 2 deletions apis/appcatalog/v1alpha1/appbinding_types.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,9 +66,9 @@ type AppBindingSpec struct {
// Required
ClientConfig ClientConfig `json:"clientConfig"`

// Secret is the name of the secret to create in the AppBinding's
// Secret is the name and type of the secret to create in the AppBinding's
// namespace that will hold the credentials associated with the AppBinding.
Secret *core.LocalObjectReference `json:"secret,omitempty"`
Secret *SecretReference `json:"secret,omitempty"`

// List of transformations that should be applied to the credentials
// associated with the ServiceBinding before they are inserted into the Secret.
Expand Down Expand Up @@ -314,3 +314,10 @@ type RemoveKeyTransform struct {
// The key to remove from the Secret
Key string `json:"key"`
}

type SecretReference struct {
// +optional
// Two possible groups: "", virtual-secrets.dev
ApiGroup string `json:"apiGroup,omitempty"`
core.LocalObjectReference `json:",inline,omitempty"`
}