fix: Fix flaky logging test - #2259
Conversation
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dsimansk The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
knative-prow
Bot
added
the
approved
![knative-prow[bot]](https://avatars.githubusercontent.com/in/183726?s=60&v=4){kind=small}
There was a problem hiding this comment.
@dsimansk: 0 warnings.
Details
In response to this:
Description
Changes
- fix: Fix flaky logging test
Reference
Fixes intermittent failures in CI runs like:
https://prow.knative.dev/view/gs/knative-prow/logs/nightly_client_main_periodic/2089279117865259008Release Note
fix: Fix flaky logging test/cc @gauron99
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
knative-prow
Bot
added
the
size/XS
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2259 +/- ##
=======================================
Coverage 71.88% 71.88%
=======================================
Files 233 233
Lines 13535 13535
=======================================
Hits 9730 9730
Misses 2999 2999
Partials 806 806 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
/lgtm |
2 participants
Description
Changes
Reference
Fixes intermittent failures in CI runs like:
https://prow.knative.dev/view/gs/knative-prow/logs/nightly_client_main_periodic/2089279117865259008
Release Note
/cc @gauron99